Add additionalMatchLabels to helm chart.#7177
Merged
xiangfu0 merged 1 commit intoapache:masterfrom Feb 14, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7177 +/- ##
============================================
- Coverage 73.49% 73.46% -0.04%
Complexity 92 92
============================================
Files 1500 1500
Lines 73758 73758
Branches 10637 10637
============================================
- Hits 54209 54183 -26
- Misses 16005 16037 +32
+ Partials 3544 3538 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangfu0
approved these changes
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
additionalMatchLabelsto the helm values to allow customization of the StatefulSets matchLabels. This configuration will allow for a safe upgrade from chart version 0.2.3 -> 0.2.5 as-is, but also allow for safe upgrades from 0.2.4 -> 0.2.5 with the addition of aadditionalMatchLabelsoption.Resolves issue: #7176
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
This PR adds a
additionalMatchLabelsoption to customize the StatefulSet match labels. This can be used to maintain multiple StatefulSets within the same kubernetes namespace or to simply maintain tighter control over the associated match labels. Special consideration should be taken when using theadditionalMatchLabelsoption as is can break backwards compatibility.If upgrading from chart version <0.2.3 then no additional configuration is needed.
If upgrading from chart verion 0.2.4 then the following option needs to be added to
values.yamlto upgrade with zero-downtime.Documentation