Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use query timeout for planning phase #5990

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

Jackie-Jiang
Copy link
Contributor

Description

Currently the CombinePlanNode is using fixed 10 seconds as the timeout for the multi-threaded query planning, and the query planning time is not counted into the timeout for the query.
This PR:

  • Replaces the fixed 10 seconds timeout with the query timeout for the query planing phase
  • Count the query planing time into the query timeout

Copy link
Contributor

@xiangfu0 xiangfu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
I think we finally make this timeout thing right ;)

@Jackie-Jiang Jackie-Jiang merged commit cd35332 into apache:master Sep 8, 2020
@Jackie-Jiang Jackie-Jiang deleted the plan_time_out branch September 8, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants