Change group key delimiter from '\t' to '\0' #5858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
force-pushed
the
group_delimiter
branch
2 times, most recently
from
4525626 to
4d0cee9
Compare
Jackie-Jiang
force-pushed
the
group_delimiter
branch
from
4d0cee9 to
1d6266c
Compare
xiangfu0
approved these changes
Aug 17, 2020
| for (int i = 0; i < numGroupByExpressions; i++) { | ||
| converterFunctions[i] = getConverterFunction(_dataSchema.getColumnDataType(i)); | ||
| } | ||
| if (numGroupByExpressions == 1) { |
There was a problem hiding this comment.
why we separate single groupby ? for performance ?
There was a problem hiding this comment.
Yes. For single group-by, we don't need to split the string for each group key
| public AggregationGroupByTrimmingService(QueryContext queryContext) { | ||
| _aggregationFunctions = queryContext.getAggregationFunctions(); | ||
| List<ExpressionContext> groupByExpressions = queryContext.getGroupByExpressions(); | ||
| assert groupByExpressions != null; |
There was a problem hiding this comment.
shall we stick to Preconditions.checkArgument?
There was a problem hiding this comment.
I usually use assert to indicate that it is not possible to be null for readability, which will be ignored in production environment.
Preconditions are used for catching the illegal user input and throw exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using '\t' as the group key delimiter will cause unexpected behavior when grouping on string value with '\t' inside. To solve it, we can use '\0' as the delimiter which is not allowed in the string values.
Upgrade Notes
In order to achieve zero down-time upgrade, Brokers must be upgraded before Servers.