Support multi-value non-dictionary group by #5851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
force-pushed
the
support_mv_non_dict_groupby
branch
5 times, most recently
from
d302180 to
b357c66
Compare
...rg/apache/pinot/core/query/aggregation/groupby/NoDictionaryMultiColumnGroupKeyGenerator.java
Outdated
Show resolved
Hide resolved
...rg/apache/pinot/core/query/aggregation/groupby/NoDictionaryMultiColumnGroupKeyGenerator.java
Outdated
Show resolved
Hide resolved
...rg/apache/pinot/core/query/aggregation/groupby/NoDictionaryMultiColumnGroupKeyGenerator.java
Outdated
Show resolved
Hide resolved
...rg/apache/pinot/core/query/aggregation/groupby/NoDictionaryMultiColumnGroupKeyGenerator.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
support_mv_non_dict_groupby
branch
2 times, most recently
from
1958438 to
0a09e9e
Compare
Jackie-Jiang
approved these changes
Aug 12, 2020
|
I think H2 does not support MV columns, so you might need to add the test into |
xiangfu0
force-pushed
the
support_mv_non_dict_groupby
branch
2 times, most recently
from
60e946d to
ca7e6b8
Compare
xiangfu0
force-pushed
the
support_mv_non_dict_groupby
branch
from
ca7e6b8 to
49d96ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support multi-value non-dictionary group by
This is triggered when groupby has one no-dict single value column and 1 multi-value column