[Post-aggregation] Support type conversion for all scalar functions #5849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
force-pushed
the
post_aggregation_3
branch
from
56fce84 to
9151514
Compare
xiangfu0
approved these changes
Aug 12, 2020
Jackie-Jiang
force-pushed
the
post_aggregation_3
branch
from
9151514 to
16e0df3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support type conversion for all scalar functions.
Parameter classes supported for type conversion using
PinotDataType:Also handle function name with underscore in
FunctionRegistry.Support type conversion for all features using the scalar function:
CalciteSqlParserInbuiltFunctionEvaluatorScalarTransformFunctionWrapperAdd
PostAggregationFunctionto handle post-aggregation calculation using the scalar function.Add
ArithmeticFunctionsfor all the arithmetic scalar functions: