Allow Pinot to accept query with FROM clause in the format of [database].[table]#5707
Merged
Allow Pinot to accept query with FROM clause in the format of [database].[table]#5707
Conversation
mayankshriv
reviewed
Jul 15, 2020
| * | ||
| * @param brokerRequest | ||
| */ | ||
| private void updateQuerySource(BrokerRequest brokerRequest) { |
Contributor
There was a problem hiding this comment.
Should this be done in PinotQuery2BrokerRequestConverter?
Contributor
Author
There was a problem hiding this comment.
I wish I could do that!
Here we don't have any information of existing table names as we are allowing dot in table name.
Contributor
Author
There was a problem hiding this comment.
Also I feel that we should introduce the concept that no dot is allowed in table name/column name.
I'm not sure if anyone is using dot in table name, but it's definitely some users are using dot in column name.
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/TableCache.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
approved these changes
Jul 16, 2020
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Show resolved
Hide resolved
…ler/BaseBrokerRequestHandler.java Co-authored-by: Xiaotian (Jackie) Jiang <17555551+Jackie-Jiang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow Pinot to accept query with FROM clause in the format of [database].[table].
Will update TableName to
[table]in BrokerRequest, when[database].[table]doesn't exist but[table]exists.For case sensitive mode (default), use RoutingManager to check table existence.
For case insensitive mode, use TableCache to check table existence.
Some thoughts here:
We should try to prevent user creating table with dot in the table name.
Release Notes
Allow Pinot to accept query with FROM clause in the format of [database].[table].