Add methods toPrettyJsonString() and toSingleLineJsonString() to Schema#3783
Merged
Jackie-Jiang merged 1 commit intomasterfrom Feb 2, 2019
Merged
Add methods toPrettyJsonString() and toSingleLineJsonString() to Schema#3783Jackie-Jiang merged 1 commit intomasterfrom
Jackie-Jiang merged 1 commit intomasterfrom
Conversation
- For human-read API, use pretty string - For other purpose, use compact single-line string Fix the issue of storing pretty string in ZK (consume more space and less readable)
Codecov Report
@@ Coverage Diff @@
## master #3783 +/- ##
============================================
+ Coverage 67.22% 67.28% +0.05%
Complexity 4 4
============================================
Files 1027 1027
Lines 50812 50816 +4
Branches 7091 7091
============================================
+ Hits 34159 34192 +33
+ Misses 14312 14286 -26
+ Partials 2341 2338 -3
Continue to review full report at Codecov.
|
snleee
approved these changes
Feb 2, 2019
Contributor
snleee
left a comment
There was a problem hiding this comment.
Do we plan to do this for table config as well? Otherwise, LGTM
Contributor
|
The impact of this change is unclear to me. Will any API responses be affected by this change? If so we should check backward compatibility implications. |
Contributor
Author
|
@sunithabeeram We support both format, and it's mainly for saving space & readability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue of storing pretty string in ZK (consume more space and less readable)