Conversation
Codecov Report
@@ Coverage Diff @@
## master #3763 +/- ##
============================================
+ Coverage 67.09% 67.17% +0.08%
Complexity 4 4
============================================
Files 1027 1027
Lines 50799 50814 +15
Branches 7091 7091
============================================
+ Hits 34082 34135 +53
+ Misses 14400 14350 -50
- Partials 2317 2329 +12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Please make sure that the table name (with type) is there in all the tables. Time is not necessary, since the log message should indicate the time of log.
I would format the message something like this:
"Deleting table {}: Start"
"Deleting table {} : Removed from broker idealstate"
"Deleting table {} : SOMETHNG ELSE"
etc.
"Deleting table {}: Done"
so that we can just look for the table that we want, and get all the deletion logs.
|
@mcvsubbu Comment addressed |
mcvsubbu
left a comment
There was a problem hiding this comment.
why do we need the time in each log/? The log line provides a msec time.
...ntroller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
Outdated
Show resolved
Hide resolved
...ntroller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
Outdated
Show resolved
Hide resolved
...ntroller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
Outdated
Show resolved
Hide resolved
...ntroller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
Outdated
Show resolved
Hide resolved
71b6015 to
aac9e03
Compare
aac9e03 to
f54d597
Compare
...ntroller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
Outdated
Show resolved
Hide resolved
928afd1 to
f538819
Compare
This PR adds logs for deleteTable API. We've seen this API taking too much time to proceed. Adding logs helps to track which part is the bottle neck.