Skip to content

[TE] Fix for anomaly legend values for non_additive daily metrics #3676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akshayrai wants to merge 1 commit into from
Closed

[TE] Fix for anomaly legend values for non_additive daily metrics #3676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...deye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/auto/onboard/ConfigGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package com.linkedin.thirdeye.auto.onboard;

import com.linkedin.thirdeye.constant.MetricAggFunction;
import com.linkedin.thirdeye.datalayer.pojo.MetricConfigBean;
import java.util.ArrayList;
import java.util.List;
Expand All @@ -38,6 +39,7 @@ public class ConfigGenerator {

private static final String PDT_TIMEZONE = "US/Pacific";
private static final String BYTES_STRING = "BYTES";
private static final String NON_ADDITIVE_TAG = "_non_additive";

public static void setTimeSpecs(DatasetConfigDTO datasetConfigDTO, TimeGranularitySpec timeSpec) {
datasetConfigDTO.setTimeColumn(timeSpec.getName());
Expand All @@ -57,6 +59,11 @@ public static DatasetConfigDTO generateDatasetConfig(String dataset, Schema sche

// Create DatasetConfig
DatasetConfigDTO datasetConfigDTO = new DatasetConfigDTO();
if (dataset != null && dataset.endsWith(NON_ADDITIVE_TAG)) {
datasetConfigDTO.setAdditive(false);
} else {
datasetConfigDTO.setAdditive(true);
}
datasetConfigDTO.setDataset(dataset);
datasetConfigDTO.setDimensions(dimensions);
setTimeSpecs(datasetConfigDTO, timeSpec);
Expand Down Expand Up @@ -91,12 +98,17 @@ public static MetricConfigDTO generateMetricConfig(MetricFieldSpec metricFieldSp
metricConfigDTO.setAlias(ThirdEyeUtils.constructMetricAlias(dataset, metric));
metricConfigDTO.setDataset(dataset);

// TODO: Discuss on how we can improve the approximation for non-additive datasets
String dataTypeStr = metricFieldSpec.getDataType().toString();
if (BYTES_STRING.equals(dataTypeStr)) {
// Assume if the column is BYTES type, use the default TDigest function and set the return data type to double
metricConfigDTO.setDefaultAggFunction(MetricConfigBean.DEFAULT_TDIGEST_AGG_FUNCTION);
metricConfigDTO.setDatatype(MetricType.DOUBLE);
} else if (dataset != null && dataset.endsWith(NON_ADDITIVE_TAG)) {
metricConfigDTO.setDefaultAggFunction(MetricAggFunction.AVG);
metricConfigDTO.setDatatype(MetricType.valueOf(dataTypeStr));
} else {
metricConfigDTO.setDefaultAggFunction(MetricAggFunction.SUM);
metricConfigDTO.setDatatype(MetricType.valueOf(dataTypeStr));
}

Expand Down
2 changes: 1 addition & 1 deletion .../thirdeye-pinot/src/main/java/com/linkedin/thirdeye/datalayer/pojo/DatasetConfigBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
public class DatasetConfigBean extends AbstractBean {

public static final String DEFAULT_COMPLETENESS_ALGORITHM = Wo4WAvgDataCompletenessAlgorithm.class.getName();
public static String DEFAULT_PREAGGREGATED_DIMENSION_VALUE = "all";
public static String DEFAULT_PREAGGREGATED_DIMENSION_VALUE = "*";
public static String DATASET_OFFLINE_PREFIX = "_OFFLINE";
public static TimeGranularity DEFAULT_HOURLY_EXPECTED_DELAY = new TimeGranularity(8, TimeUnit.HOURS);
public static TimeGranularity DEFAULT_DAILY_EXPECTED_DELAY = new TimeGranularity(36, TimeUnit.HOURS);
Expand Down