Skip to content

Add broker config to support configuring planner rules disabled by default#17258

Merged
yashmayya merged 2 commits intoapache:masterfrom
yashmayya:disable-planner-rules-broker-config
Nov 27, 2025
Merged

Add broker config to support configuring planner rules disabled by default#17258
yashmayya merged 2 commits intoapache:masterfrom
yashmayya:disable-planner-rules-broker-config

Conversation

@yashmayya
Copy link
Contributor

@yashmayya yashmayya added enhancement multi-stage Related to the multi-stage query engine labels Nov 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.21%. Comparing base (687770e) to head (cc02c47).
⚠️ Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
...requesthandler/MultiStageBrokerRequestHandler.java 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17258      +/-   ##
============================================
- Coverage     63.22%   63.21%   -0.01%     
  Complexity     1433     1433              
============================================
  Files          3128     3133       +5     
  Lines        185689   186078     +389     
  Branches      28380    28408      +28     
============================================
+ Hits         117399   117634     +235     
- Misses        59228    59371     +143     
- Partials       9062     9073      +11     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.20% <85.00%> (+<0.01%) ⬆️
java-21 63.17% <85.00%> (+0.01%) ⬆️
temurin 63.21% <85.00%> (-0.01%) ⬇️
unittests 63.21% <85.00%> (-0.01%) ⬇️
unittests1 55.63% <100.00%> (+0.03%) ⬆️
unittests2 33.86% <75.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yashmayya yashmayya requested a review from xiangfu0 November 25, 2025 22:39
@Jackie-Jiang Jackie-Jiang added documentation Configuration Config changes (addition/deletion/change in behavior) labels Nov 26, 2025
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@yashmayya yashmayya force-pushed the disable-planner-rules-broker-config branch from 86fcf95 to cc02c47 Compare November 26, 2025 23:27
@yashmayya yashmayya merged commit 57f94f3 into apache:master Nov 27, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Configuration Config changes (addition/deletion/change in behavior) documentation enhancement multi-stage Related to the multi-stage query engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants