Modify AdaptiveSizeBasedWriter based on available capacity on disk#16803
Merged
KKcorps merged 11 commits intoapache:masterfrom Sep 23, 2025
Merged
Modify AdaptiveSizeBasedWriter based on available capacity on disk#16803KKcorps merged 11 commits intoapache:masterfrom
KKcorps merged 11 commits intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #16803 +/- ##
============================================
+ Coverage 63.38% 63.40% +0.02%
Complexity 1410 1410
============================================
Files 3061 3062 +1
Lines 179692 179781 +89
Branches 27510 27517 +7
============================================
+ Hits 113893 113994 +101
+ Misses 57011 56997 -14
- Partials 8788 8790 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...c/main/java/org/apache/pinot/core/segment/processing/genericrow/AdaptiveSizeBasedWriter.java
Show resolved
Hide resolved
Contributor
swaminathanmanish
left a comment
There was a problem hiding this comment.
LGTM otherwise !
.../main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorFramework.java
Show resolved
Hide resolved
swaminathanmanish
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently AdaptiveSizeBasedWriter (added in #12220) checks based on configured max bytes to be written. This config doesn't take into account other writers writing to the same file store. And thus, it becomes harder to manage.
In this PR, I am adding a check while takes into account the free disk space available and thus is more adaptive and easier to manage. The config added defines the maximum allowed disk usage percentage for the underlying file store.
To preserve backward compatibility the default is kept to 100%
Release Notes:
Testing Notes :
Logs from test run