Skip to content

[multistage] Handle Column Less Tuples in BlockSplitter#16058

Merged
itschrispeck merged 1 commit intoapache:masterfrom
ankitsultana:mse-block-splitter
Jun 10, 2025
Merged

[multistage] Handle Column Less Tuples in BlockSplitter#16058
itschrispeck merged 1 commit intoapache:masterfrom
ankitsultana:mse-block-splitter

Conversation

@ankitsultana
Copy link
Contributor

@ankitsultana ankitsultana commented Jun 10, 2025

Small change to fix broken support for column less tuples.

This issue was caught while I was working on #15958.

Not adding new tests for this since it will be covered by #15958.

Verified the fix with Colocated Join Quickstart:

SET useMultistageEngine=true;
SET usePhysicalOptimizer=true;

select COUNT(*) OVER() from userAttributes

@ankitsultana ankitsultana added bugfix multi-stage Related to the multi-stage query engine labels Jun 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.39%. Comparing base (1a476de) to head (9a0d7bb).
Report is 225 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16058      +/-   ##
============================================
+ Coverage     62.90%   63.39%   +0.49%     
+ Complexity     1386     1355      -31     
============================================
  Files          2867     2913      +46     
  Lines        163354   167138    +3784     
  Branches      24952    25553     +601     
============================================
+ Hits         102755   105960    +3205     
- Misses        52847    53155     +308     
- Partials       7752     8023     +271     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.33% <100.00%> (+0.46%) ⬆️
java-21 63.33% <100.00%> (+0.51%) ⬆️
skip-bytebuffers-false ?
skip-bytebuffers-true ?
temurin 63.39% <100.00%> (+0.49%) ⬆️
unittests 63.39% <100.00%> (+0.49%) ⬆️
unittests1 56.50% <100.00%> (+0.68%) ⬆️
unittests2 33.44% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itschrispeck itschrispeck merged commit a5bc956 into apache:master Jun 10, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix multi-stage Related to the multi-stage query engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants