Skip to content

Add validations for Pauseless Tables #15567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KKcorps merged 3 commits into from
Apr 25, 2025
Merged

Add validations for Pauseless Tables #15567

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e677c85
Validate peer download scheme is set when creating a pauseless table
Apr 16, 2025
b15a77d
Fix tests
Apr 23, 2025
b2d01d5
Enforce peer download scheme only when rf > 1
Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,7 @@ private static void validateValidationConfig(TableConfig tableConfig, Schema sch

String peerSegmentDownloadScheme = validationConfig.getPeerSegmentDownloadScheme();
if (peerSegmentDownloadScheme != null) {
if (!CommonConstants.HTTP_PROTOCOL.equalsIgnoreCase(peerSegmentDownloadScheme)
&& !CommonConstants.HTTPS_PROTOCOL.equalsIgnoreCase(peerSegmentDownloadScheme)) {
if (!isValidPeerDownloadScheme(peerSegmentDownloadScheme)) {
throw new IllegalStateException("Invalid value '" + peerSegmentDownloadScheme
+ "' for peerSegmentDownloadScheme. Must be one of http or https");
}
Expand All @@ -317,6 +316,11 @@ private static void validateValidationConfig(TableConfig tableConfig, Schema sch
validateRetentionConfig(tableConfig);
}

private static boolean isValidPeerDownloadScheme(String peerSegmentDownloadScheme) {
return CommonConstants.HTTP_PROTOCOL.equalsIgnoreCase(peerSegmentDownloadScheme)
|| CommonConstants.HTTPS_PROTOCOL.equalsIgnoreCase(peerSegmentDownloadScheme);
}

/**
* Validates the following:
* 1. validity of filter function
Expand Down Expand Up @@ -364,6 +368,21 @@ public static void validateIngestionConfig(TableConfig tableConfig, Schema schem
List<Map<String, String>> streamConfigMaps = ingestionConfig.getStreamIngestionConfig().getStreamConfigMaps();
Preconditions.checkState(!streamConfigMaps.isEmpty(), "Must have at least 1 stream in REALTIME table");
// TODO: for multiple stream configs, validate them

boolean isPauselessEnabled = ingestionConfig.getStreamIngestionConfig().isPauselessConsumptionEnabled();
if (isPauselessEnabled) {
int replication = tableConfig.getReplication();
// We are checking for this only when replication is greater than 1 because in test environments
// users still prefer to create pauseless tables with replication 1
if (replication > 1) {
String peerSegmentDownloadScheme = tableConfig.getValidationConfig().getPeerSegmentDownloadScheme();
Preconditions.checkState(StringUtils.isNotEmpty(peerSegmentDownloadScheme) && isValidPeerDownloadScheme(
peerSegmentDownloadScheme),
"Must have a valid peerSegmentDownloadScheme set in validation config for pauseless consumption");
} else {
LOGGER.warn("It's not recommended to create pauseless tables with replication 1 for stability reasons.");
}
}
}

// Filter config
Expand Down
Loading