Adds Intgeration tests for Dedup and Pauseless#15398
Merged
KKcorps merged 7 commits intoapache:masterfrom May 2, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15398 +/- ##
============================================
- Coverage 62.82% 62.81% -0.01%
Complexity 1384 1384
============================================
Files 2864 2864
Lines 162671 162671
Branches 24902 24902
============================================
- Hits 102191 102189 -2
- Misses 52782 52788 +6
+ Partials 7698 7694 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds integration tests for deduplication and pauseless real‐time ingestion, enforcing consumption in order. Key changes include:
- Introducing a new test (PauselessRealtimeIngestionWithDedupIntegrationTest) that enables pauseless consumption.
- Updating the ingestion configuration across multiple test files to enforce consumption order.
- Refactoring builder chains for consistency in table configuration construction.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/PauselessRealtimeIngestionWithDedupIntegrationTest.java | Adds a new integration test that sets pauseless consumption enabled on the ingestion configuration. |
| pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/DedupPreloadIntegrationTest.java | Updates ingestion configuration and reformats the table config builder chain. |
| pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseDedupIntegrationTest.java | Adds an override for getIngestionConfig() and updates the table configuration builder chain. |
| pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java | Refactors the table config builder chain to match the new formatting style and ingestion config changes. |
KKcorps
reviewed
Apr 23, 2025
| IngestionConfig ingestionConfig = super.getIngestionConfig(); | ||
| assert ingestionConfig != null; | ||
| assert ingestionConfig.getStreamIngestionConfig() != null; | ||
| ingestionConfig.getStreamIngestionConfig().setPauselessConsumptionEnabled(true); |
Contributor
There was a problem hiding this comment.
Should we not enable rest of the pauseless + dedup configs here like parallel consumption policy?
Contributor
Author
There was a problem hiding this comment.
They will be enabled from line 27.
IngestionConfig ingestionConfig = super.getIngestionConfig();
KKcorps
approved these changes
May 2, 2025
Contributor
|
@KKcorps @noob-se7en : has this broken tests on master? Seeing this in my PR: |
Contributor
|
@ankitsultana that is due to a different PR |
Contributor
|
@noob-se7en can you please fix this test to address the error |
Contributor
Author
|
yep just saw as well |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Intgeration tests for Dedup and Pauseless enforcing consumption in order.