Merged
Conversation
gortiz
added
incompatible
Closed
Codecov Report❌ Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jackie-Jiang
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency and all usages of LArray, as the last final PR to implement #12810.
As mentioned, LArray is the library we used to use to support buffers longer than 2GBs. However, it has several issues, and our library has replaced it. In the future, we would like to work directly on top of the new standard Foreign Memory API introduced in Java 22.
This PR is backward incompatible, although most users should not notice the change. In Pinot 1.2.0, we used our library when running on Java 17 and 21, and in Pinot 1.3.0, we made our library the default in all deployments. The only way users could be using larray is by changing
pinot.offheap.buffer.factory. In Pinot 1.4.0 this configuration won't support the valuelarray.The buffer API used by Pinot can be configured with plugins (as shown in #12809). In case some user actually wants to keep using LArray, they could create their own plugin using the code that is being removed here. I would strongly recommend against that (as it is discussed in #12810), but I just wanted to mention this in the strange case someone actually prefer LArray.