Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15223 +/- ##
============================================
+ Coverage 61.75% 63.57% +1.81%
- Complexity 207 1461 +1254
============================================
Files 2436 2761 +325
Lines 133233 155613 +22380
Branches 20636 23929 +3293
============================================
+ Hits 82274 98926 +16652
- Misses 44911 49241 +4330
- Partials 6048 7446 +1398
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gortiz
approved these changes
Mar 10, 2025
Contributor
|
@Jackie-Jiang Added a test case for this in #15244 Should we merge that PR to this branch ? Or should I wait for this PR to be merged first and then merge the test case to master ? |
yashmayya
reviewed
Mar 18, 2025
Contributor
yashmayya
left a comment
yashmayya
left a comment
There was a problem hiding this comment.
@krishan1390 you can rebase your PR on the latest master and I can then merge yours as well, thanks.
tsekityam
pushed a commit
to tsekityam/pinot
that referenced
this pull request
Mar 19, 2025
yashmayya
pushed a commit
to yashmayya/pinot
that referenced
this pull request
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14893 accidentally removed the
workerIdToSegmentsMapand broke LOOKUP join. This PR adds that back. Tested withLookupJoinEngineQuickStartTODO: Add a query test for LOOKUP join