Skip to content

Allow using hint to force enable/disable colocated join#14912

Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:force_colocate_join
Jan 29, 2025
Merged

Allow using hint to force enable/disable colocated join#14912
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:force_colocate_join

Conversation

@Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented Jan 24, 2025

It can be used in 2 scenarios:

  1. When the distribution trait is not able to detect the colocation, force enabling it
  2. Force disabling it for debugging purpose

@Jackie-Jiang Jackie-Jiang added enhancement multi-stage Related to the multi-stage query engine labels Jan 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.70%. Comparing base (59551e4) to head (f61b44a).
Report is 1642 commits behind head on master.

Files with missing lines Patch % Lines
...inot/calcite/rel/logical/PinotLogicalExchange.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14912      +/-   ##
============================================
+ Coverage     61.75%   63.70%   +1.95%     
- Complexity      207     1472    +1265     
============================================
  Files          2436     2708     +272     
  Lines        133233   151776   +18543     
  Branches      20636    23438    +2802     
============================================
+ Hits          82274    96686   +14412     
- Misses        44911    47823    +2912     
- Partials       6048     7267    +1219     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.68% <96.66%> (+1.97%) ⬆️
java-21 63.59% <96.66%> (+1.97%) ⬆️
skip-bytebuffers-false 63.70% <96.66%> (+1.95%) ⬆️
skip-bytebuffers-true 63.57% <96.66%> (+35.84%) ⬆️
temurin 63.70% <96.66%> (+1.95%) ⬆️
unittests 63.69% <96.66%> (+1.95%) ⬆️
unittests1 56.26% <96.66%> (+9.37%) ⬆️
unittests2 34.01% <0.00%> (+6.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 1585490 into apache:master Jan 29, 2025
20 of 21 checks passed
@Jackie-Jiang Jackie-Jiang deleted the force_colocate_join branch January 29, 2025 01:54
zeronerdzerogeekzerocool pushed a commit to zeronerdzerogeekzerocool/pinot that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement multi-stage Related to the multi-stage query engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants