Fix a bug for partition enabled instance assignment with minimize movement

[Jackie-Jiang]

Fix #14151

The main fix is the one line change in InstanceReplicaGroupPartitionSelector where the max partitions per instance calculation is wrong.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.86%. Comparing base (59551e4) to head (ebe5296).
Report is 1517 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #14726      +/-   ##
============================================
+ Coverage     61.75%   63.86%   +2.10%     
- Complexity      207     1607    +1400     
============================================
  Files          2436     2703     +267     
  Lines        133233   150648   +17415     
  Branches      20636    23270    +2634     
============================================
+ Hits          82274    96205   +13931     
- Misses        44911    47248    +2337     
- Partials       6048     7195    +1147     

Flag	Coverage Δ
custom-integration1	100.00% <ø> (+99.99%)	⬆️
integration	100.00% <ø> (+99.99%)	⬆️
integration1	100.00% <ø> (+99.99%)	⬆️
integration2	0.00% <ø> (ø)
java-11	63.81% <100.00%> (+2.10%)	⬆️
java-21	63.71% <100.00%> (+2.09%)	⬆️
skip-bytebuffers-false	63.82% <100.00%> (+2.08%)	⬆️
skip-bytebuffers-true	63.70% <100.00%> (+35.97%)	⬆️
temurin	63.86% <100.00%> (+2.10%)	⬆️
unittests	63.85% <100.00%> (+2.10%)	⬆️
unittests1	56.25% <ø> (+9.36%)	⬆️
unittests2	34.20% <100.00%> (+6.47%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.