[timeseries] Part-1: Misc. Refactor to Enable Broker Reduce #14582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitsultana
added
the
timeseries-engine
ankitsultana
commented
Dec 3, 2024
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14582 +/- ##
============================================
+ Coverage 61.75% 63.97% +2.22%
- Complexity 207 1569 +1362
============================================
Files 2436 2683 +247
Lines 133233 147352 +14119
Branches 20636 22590 +1954
============================================
+ Hits 82274 94268 +11994
- Misses 44911 46141 +1230
- Partials 6048 6943 +895
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
raghavyadav01
approved these changes
Dec 4, 2024
...not-timeseries-m3ql/src/main/java/org/apache/pinot/tsdb/m3ql/plan/TransformNullPlanNode.java
Show resolved
Hide resolved
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java
Show resolved
Hide resolved
| @@ -54,6 +55,11 @@ public ExecutorService getExecutorService() { | |||
| return _executorService; | |||
| } | |||
|
|
|||
| @Override | |||
| public BaseTimeSeriesPlanNode withInputs(List<BaseTimeSeriesPlanNode> newInputs) { | |||
There was a problem hiding this comment.
What is the idea behind withInputs?
There was a problem hiding this comment.
This is to enable plan cloning, which allows replacing sub-trees of the plan.
There was a problem hiding this comment.
in MSQ we also use it when executing the explain plan that includes segment information (aka indexes).
tibrewalpratik17
approved these changes
Dec 4, 2024
davecromberge
pushed a commit
to davecromberge/pinot
that referenced
this pull request
Dec 10, 2024
zeronerdzerogeekzerocool
pushed a commit
to zeronerdzerogeekzerocool/pinot
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
First of the multi-part PRs to enable Broker Reduce for the Time Series Engine.
This PR does the following:
childreferences toinputsto be consistent with pinot-query-planner PlanNode.withInputsto allow sub-plan cloning in the future.GrpcSendingMailboxtoDataBlockUtils. For Broker Reduce, we will send a row basedTransferableBlockfrom the servers to the brokers.Note: This is a breaking change for the
pinot-timeseries-spi, but that should be okay since that spi is marked Unstable and is evolving rapidly.Test Plan
Ran the Quickstart on local. After the 3-part PRs we will be testing the build out in one of our clusters for scale/perf testing.