Allow to set targetInstance for reloadSegment #14393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
approved these changes
Nov 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14393 +/- ##
============================================
+ Coverage 61.75% 63.75% +2.00%
- Complexity 207 1554 +1347
============================================
Files 2436 2660 +224
Lines 133233 145966 +12733
Branches 20636 22355 +1719
============================================
+ Hits 82274 93065 +10791
- Misses 44911 46020 +1109
- Partials 6048 6881 +833
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
davecromberge
pushed a commit
to davecromberge/pinot
that referenced
this pull request
Nov 22, 2024
yashmayya
pushed a commit
to yashmayya/pinot
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like resetSegment, allow one to specify target instance when reloading segments, and refined the API response msg when not able to find segments on the target instances.
Tested locally with quickStart.