Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix real-time validation NPE when stream partition no longer available #14392

Merged

Conversation

Jackie-Jiang
Copy link
Contributor

When a stream partition is no longer available (reached end of life), trying to create a consuming segment for it can cause NPE.
This PR fixes the problem by not creating new consuming segment for partitions that have already reached end of life.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 60.52632% with 15 lines in your changes missing coverage. Please review.

Project coverage is 63.78%. Comparing base (59551e4) to head (1d3601d).
Report is 1289 commits behind head on master.

Files with missing lines Patch % Lines
.../core/realtime/PinotLLCRealtimeSegmentManager.java 60.52% 11 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14392      +/-   ##
============================================
+ Coverage     61.75%   63.78%   +2.02%     
- Complexity      207     1555    +1348     
============================================
  Files          2436     2660     +224     
  Lines        133233   145961   +12728     
  Branches      20636    22345    +1709     
============================================
+ Hits          82274    93096   +10822     
- Misses        44911    45989    +1078     
- Partials       6048     6876     +828     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.74% <60.52%> (+2.03%) ⬆️
java-21 63.67% <60.52%> (+2.04%) ⬆️
skip-bytebuffers-false 63.77% <60.52%> (+2.03%) ⬆️
skip-bytebuffers-true 63.63% <60.52%> (+35.90%) ⬆️
temurin 63.78% <60.52%> (+2.02%) ⬆️
unittests 63.77% <60.52%> (+2.02%) ⬆️
unittests1 55.49% <ø> (+8.60%) ⬆️
unittests2 34.15% <60.52%> (+6.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit b273094 into apache:master Nov 5, 2024
21 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_non_existing_partition branch November 5, 2024 23:26
davecromberge pushed a commit to davecromberge/pinot that referenced this pull request Nov 22, 2024
npawar pushed a commit that referenced this pull request Feb 13, 2025
…reduced after creating the table (#15028)

Adding a testcase to reproduce the behavior fixed in #14392 PR.
zeronerdzerogeekzerocool pushed a commit to zeronerdzerogeekzerocool/pinot that referenced this pull request Feb 20, 2025
…reduced after creating the table (apache#15028)

Adding a testcase to reproduce the behavior fixed in apache#14392 PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants