do not add column name separator on download#14303
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Oct 27, 2024
Merged
do not add column name separator on download#14303Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang merged 1 commit intoapache:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14303 +/- ##
============================================
+ Coverage 61.75% 63.74% +1.99%
- Complexity 207 1555 +1348
============================================
Files 2436 2659 +223
Lines 133233 145448 +12215
Branches 20636 22219 +1583
============================================
+ Hits 82274 92718 +10444
- Misses 44911 45886 +975
- Partials 6048 6844 +796
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jadami10
changed the title
Jackie-Jiang
approved these changes
Oct 27, 2024
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a
uibugfixthat closes #14302columnNameSeparator was added in #8131 to allow displaying columns with the same name. But we don't need to carry that over when downloading the data.
I ran pinot locally and ensured downloaded data was identical except for
#$%\dno longer being in the column name