bugfix: TextMatchFilterOptimizer grouping for inner compound query #14299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14299 +/- ##
============================================
+ Coverage 61.75% 63.73% +1.98%
- Complexity 207 1557 +1350
============================================
Files 2436 2659 +223
Lines 133233 145451 +12218
Branches 20636 22219 +1583
============================================
+ Hits 82274 92710 +10436
- Misses 44911 45894 +983
- Partials 6048 6847 +799
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this edge case when adding TextMatchFilterOptimizer.
For a query such as
text_match(col1, 'aaa') AND text_match(col1, 'bbb OR ccc'), this would have previously been optimized totext_match(col1, '(foo AND bar OR baz)', which would return unexpected results.Applying grouping for each filter (instead of at the merged filter level) produces an faithful translation to
text_match(col1, '(foo) AND (bar OR baz)'.