Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing precondition check for V5 writer version in BaseChunkForwardIndexWriter #14265

Conversation

jackluo923
Copy link
Contributor

This PR adds a missing precondition check for the V5 writer version introduced in PR #14105. Specifically, it ensures proper handling of the V5 writer version in BaseChunkForwardIndexWriter.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.73%. Comparing base (59551e4) to head (3cfdebb).
Report is 1208 commits behind head on master.

Files with missing lines Patch % Lines
...al/io/writer/impl/BaseChunkForwardIndexWriter.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14265      +/-   ##
============================================
+ Coverage     61.75%   63.73%   +1.98%     
- Complexity      207     1537    +1330     
============================================
  Files          2436     2626     +190     
  Lines        133233   144674   +11441     
  Branches      20636    22141    +1505     
============================================
+ Hits          82274    92214    +9940     
- Misses        44911    45648     +737     
- Partials       6048     6812     +764     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 55.38% <0.00%> (-6.33%) ⬇️
java-21 63.62% <0.00%> (+2.00%) ⬆️
skip-bytebuffers-false 63.73% <0.00%> (+1.98%) ⬆️
skip-bytebuffers-true 63.58% <0.00%> (+35.85%) ⬆️
temurin 63.73% <0.00%> (+1.98%) ⬆️
unittests 63.73% <0.00%> (+1.98%) ⬆️
unittests1 55.44% <0.00%> (+8.55%) ⬆️
unittests2 34.30% <0.00%> (+6.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 merged commit 0382dea into apache:master Oct 21, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants