Add NULLIF scalar function #14203
Merged
Add NULLIF scalar function #14203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmayya
force-pushed
the
nullif-function
branch
from
e8138d6
to
c86fd65
Compare
yashmayya
added
feature
release-notes
yashmayya
force-pushed
the
nullif-function
branch
from
c86fd65
to
536db51
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14203 +/- ##
============================================
+ Coverage 61.75% 63.69% +1.93%
- Complexity 207 1450 +1243
============================================
Files 2436 2622 +186
Lines 133233 144399 +11166
Branches 20636 22105 +1469
============================================
+ Hits 82274 91969 +9695
- Misses 44911 45632 +721
- Partials 6048 6798 +750
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Fixes #14207 |
Jackie-Jiang
approved these changes
Oct 10, 2024
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ObjectFunctions.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NULLIFstandard SQL function (exists in Postgres, MySQL, SQL Server, Calcite etc.)NULLIFexpressions are rewritten to the equivalentCASE WHENexpressions by Calcite by default (https://github.com/apache/calcite/blob/7ce986fbc635722f3390b81dcdfe24bbd82ddb3d/core/src/main/java/org/apache/calcite/sql/fun/SqlNullifFunction.java#L56-L72). So, for the multi-stage engine, simply adding theSqlStdOperatorTable.NULLIFentry to Pinot's operator table would be enough to get this functionality. However, we're also adding the scalar function implementation here so that the same function can be used in the single-stage engine as well.Edit: this is actually fixing a regression for the multi-stage query engine. Prior to #13573, the
NULLIFfunction worked fine (only on the multi-stage engine, and not on the single-stage engine). Before that refactor, Pinot's operator table extended Calcite'sSqlStdOperatorTablewhich has theSqlNullifFunctiondefined. Since it automatically rewrites calls to equivalent calls toCASE WHEN, this worked fine even though Pinot didn't have an actual implementation forNULLIF. However, the above linked PR updated Pinot's operator table to no longer extend Calcite'sSqlStdOperatorTable, and instead manually register all the operators that Pinot actually has support for. Since Pinot didn't have an actual implementation forNULLIF, it was probably missed. This PR fixes the regression and also adds support for the function in the single-stage engine.