-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bug in Handling Empty Filters in Time Series + Minor Fixes #14192
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14192 +/- ##
============================================
+ Coverage 61.75% 63.80% +2.05%
- Complexity 207 1536 +1329
============================================
Files 2436 2622 +186
Lines 133233 144378 +11145
Branches 20636 22094 +1458
============================================
+ Hits 82274 92122 +9848
- Misses 44911 45458 +547
- Partials 6048 6798 +750
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -72,7 +71,9 @@ public String getKlass() { | |||
|
|||
@Override | |||
public String getExplainName() { | |||
return EXPLAIN_NAME; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make the changes to trigger the dump of physical and logical plan from client for timeseries? As of now we do not have a way to dump similar to explain in SQL query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember we just added a new explain mode that is quite more useful that the normal one we have in V2: #13733
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think we should wait for the multistage-engine integration before explain plan support, so we have a cohesive way to compute them. The new explain mode is quite cool and we should support similar semantics for the time-series engine too. I'll be raising a proposal this month.
We were getting NPE for empty filters since transform operator can return a null value block. This handles that case, and additionally