Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug in Handling Empty Filters in Time Series + Minor Fixes #14192

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

ankitsultana
Copy link
Contributor

We were getting NPE for empty filters since transform operator can return a null value block. This handles that case, and additionally

  • Improve the explain name for Leaf Time Series Plan node.
  • Improves some QueryContextUtils methods which are used in places like segment pruner service.

@ankitsultana ankitsultana added the timeseries-engine Tracking tag for generic time-series engine work label Oct 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.80%. Comparing base (59551e4) to head (6edb226).
Report is 1163 commits behind head on master.

Files with missing lines Patch % Lines
...ator/timeseries/TimeSeriesAggregationOperator.java 0.00% 2 Missing and 1 partial ⚠️
...query/request/context/utils/QueryContextUtils.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14192      +/-   ##
============================================
+ Coverage     61.75%   63.80%   +2.05%     
- Complexity      207     1536    +1329     
============================================
  Files          2436     2622     +186     
  Lines        133233   144378   +11145     
  Branches      20636    22094    +1458     
============================================
+ Hits          82274    92122    +9848     
- Misses        44911    45458     +547     
- Partials       6048     6798     +750     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.75% <42.85%> (+2.04%) ⬆️
java-21 63.70% <42.85%> (+2.07%) ⬆️
skip-bytebuffers-false 63.80% <42.85%> (+2.05%) ⬆️
skip-bytebuffers-true 63.66% <42.85%> (+35.93%) ⬆️
temurin 63.80% <42.85%> (+2.05%) ⬆️
unittests 63.80% <42.85%> (+2.05%) ⬆️
unittests1 55.50% <14.28%> (+8.61%) ⬆️
unittests2 34.32% <28.57%> (+6.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -72,7 +71,9 @@ public String getKlass() {

@Override
public String getExplainName() {
return EXPLAIN_NAME;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the changes to trigger the dump of physical and logical plan from client for timeseries? As of now we do not have a way to dump similar to explain in SQL query.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember we just added a new explain mode that is quite more useful that the normal one we have in V2: #13733

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we should wait for the multistage-engine integration before explain plan support, so we have a cohesive way to compute them. The new explain mode is quite cool and we should support similar semantics for the time-series engine too. I'll be raising a proposal this month.

@ankitsultana ankitsultana merged commit 4257bcb into apache:master Oct 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix timeseries-engine Tracking tag for generic time-series engine work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants