Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring Theta and Tuple aggregation functions #14167

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Add support for configuring Theta and Tuple aggregation functions #14167

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
736c493
Add support for configuring Theta and Tuple aggregation function para…
davecromberge Oct 4, 2024
20f21a9
Fix checkstyle violations
davecromberge Oct 4, 2024
5671705
Rename and consolidate constant
davecromberge Oct 7, 2024
a598538
Make correction to inline documentation
davecromberge Oct 7, 2024
b32b9e0
Formatting corrections to inline documentation
davecromberge Oct 7, 2024
9a64fdd
Remove duplicate test case assertions for custom nominal entries
davecromberge Oct 7, 2024
ed0133b
Explanation for LEQ check on `canUseStarTree` for Datasketches
davecromberge Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove duplicate test case assertions for custom nominal entries
  • Loading branch information
@davecromberge
davecromberge committed Oct 7, 2024
commit 9a64fddaa36e3c779200bcf5133e708c0eb97699
8 changes: 0 additions & 8 deletions ...inot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunctionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,6 @@ public void testCanUseStarTreeDefaultK() {
Assert.assertTrue(function.canUseStarTree(Map.of(Constants.THETA_TUPLE_SKETCH_NOMINAL_ENTRIES, "4096")));
Assert.assertTrue(function.canUseStarTree(Map.of(Constants.THETA_TUPLE_SKETCH_NOMINAL_ENTRIES, 4096)));
Assert.assertFalse(function.canUseStarTree(Map.of(Constants.THETA_TUPLE_SKETCH_NOMINAL_ENTRIES, 2048)));

function = new DistinctCountThetaSketchAggregationFunction(List.of(ExpressionContext.forIdentifier("col"),
ExpressionContext.forLiteral(Literal.stringValue("nominalEntries=16384"))));

Assert.assertTrue(function.canUseStarTree(Map.of()));
Assert.assertTrue(function.canUseStarTree(Map.of(Constants.THETA_TUPLE_SKETCH_NOMINAL_ENTRIES, "16384")));
Assert.assertTrue(function.canUseStarTree(Map.of(Constants.THETA_TUPLE_SKETCH_NOMINAL_ENTRIES, 16384)));
Assert.assertFalse(function.canUseStarTree(Map.of(Constants.THETA_TUPLE_SKETCH_NOMINAL_ENTRIES, 8192)));
}

@Test
Expand Down
9 changes: 0 additions & 9 deletions ...ache/pinot/core/query/aggregation/function/IntegerTupleSketchAggregationFunctionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,6 @@ public void testCanUseStarTreeDefaultK() {
Assert.assertTrue(function.canUseStarTree(Map.of(Constants.THETA_TUPLE_SKETCH_NOMINAL_ENTRIES, "16384")));
Assert.assertTrue(function.canUseStarTree(Map.of(Constants.THETA_TUPLE_SKETCH_NOMINAL_ENTRIES, 16384)));
Assert.assertFalse(function.canUseStarTree(Map.of(Constants.THETA_TUPLE_SKETCH_NOMINAL_ENTRIES, 8192)));

function = new IntegerTupleSketchAggregationFunction(
List.of(ExpressionContext.forIdentifier("col"), ExpressionContext.forLiteral(Literal.intValue(16384))),
IntegerSummary.Mode.Sum);

Assert.assertTrue(function.canUseStarTree(Map.of()));
Assert.assertTrue(function.canUseStarTree(Map.of(Constants.THETA_TUPLE_SKETCH_NOMINAL_ENTRIES, "16384")));
Assert.assertTrue(function.canUseStarTree(Map.of(Constants.THETA_TUPLE_SKETCH_NOMINAL_ENTRIES, 16384)));
Assert.assertFalse(function.canUseStarTree(Map.of(Constants.THETA_TUPLE_SKETCH_NOMINAL_ENTRIES, 8192)));
}

@Test
Expand Down