Extract common utils used to preload segments for future reuse #14161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klsince
commented
Oct 3, 2024
| if (isOutOfMetadataTTL(segment)) { | ||
| _logger.info("Skip removing segment: {} because it's out of TTL", segmentName); | ||
| skipRemoveMetadata = true; | ||
| } |
There was a problem hiding this comment.
this is a quick fix not quite related to the refactoring on preloading. Basically, move the check into try-catch in case isOutOfMetadataTTL throws exception, which should be rare but just in case.
Jackie-Jiang
approved these changes
Oct 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14161 +/- ##
============================================
+ Coverage 61.75% 63.81% +2.06%
- Complexity 207 1532 +1325
============================================
Files 2436 2621 +185
Lines 133233 144117 +10884
Branches 20636 22053 +1417
============================================
+ Hits 82274 91970 +9696
- Misses 44911 45350 +439
- Partials 6048 6797 +749
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract common utils from preloading upsert tables, as they can be reused for dedup table as well. Preloading dedup and upsert segments is similar, as only writes are needed, w/o costly checks of metadata.
This PR refactored upsert preloading, pretty mechanically. Preloading dedup table will be added in following PRs.