Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Default RecordReader Next Implementation #14108

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

ashishjayamohan
Copy link
Contributor

  • Adds default implementation for RecordReader interface next() function
  • Deletes redundant next function implementations
  • Adds override to scala function redefinition

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.03%. Comparing base (59551e4) to head (4fec0be).
Report is 1130 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14108      +/-   ##
============================================
+ Coverage     61.75%   64.03%   +2.28%     
- Complexity      207     1531    +1324     
============================================
  Files          2436     2597     +161     
  Lines        133233   143337   +10104     
  Branches      20636    21959    +1323     
============================================
+ Hits          82274    91782    +9508     
+ Misses        44911    44801     -110     
- Partials       6048     6754     +706     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.98% <100.00%> (+2.27%) ⬆️
java-21 63.92% <100.00%> (+2.30%) ⬆️
skip-bytebuffers-false 64.01% <100.00%> (+2.27%) ⬆️
skip-bytebuffers-true 63.89% <100.00%> (+36.17%) ⬆️
temurin 64.03% <100.00%> (+2.28%) ⬆️
unittests 64.02% <100.00%> (+2.28%) ⬆️
unittests1 55.69% <100.00%> (+8.80%) ⬆️
unittests2 34.49% <100.00%> (+6.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashishjayamohan ashishjayamohan marked this pull request as ready for review September 28, 2024 00:59
@ashishjayamohan
Copy link
Contributor Author

@Jackie-Jiang Any chance you could take a look at this?

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Jackie-Jiang Jackie-Jiang merged commit 6d0ac8b into apache:master Oct 3, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants