Skip to content

Code format fixes for HashJoinOperator #13933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gortiz merged 1 commit into from
Sep 4, 2024
Merged

Code format fixes for HashJoinOperator #13933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions ...query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,8 @@ private void buildBroadcastHashTable()
_statMap.merge(StatKey.TIME_BUILDING_HASH_TABLE_MS, System.currentTimeMillis() - startTime);
}

private TransferableBlock buildJoinedDataBlock() throws ProcessingException {
private TransferableBlock buildJoinedDataBlock()
throws ProcessingException {
// Keep reading the input blocks until we find a match row or all blocks are processed.
// TODO: Consider batching the rows to improve performance.
while (true) {
Expand Down Expand Up @@ -305,7 +306,8 @@ private TransferableBlock buildJoinedDataBlock() throws ProcessingException {
}
}

private List<Object[]> buildJoinedRows(TransferableBlock leftBlock) throws ProcessingException {
private List<Object[]> buildJoinedRows(TransferableBlock leftBlock)
throws ProcessingException {
switch (_joinType) {
case SEMI:
return buildJoinedDataBlockSemi(leftBlock);
Expand All @@ -317,7 +319,8 @@ private List<Object[]> buildJoinedRows(TransferableBlock leftBlock) throws Proce
}
}

private List<Object[]> buildJoinedDataBlockSemi(TransferableBlock leftBlock) throws ProcessingException {
private List<Object[]> buildJoinedDataBlockSemi(TransferableBlock leftBlock)
throws ProcessingException {
List<Object[]> container = leftBlock.getContainer();
List<Object[]> rows = new ArrayList<>(container.size());

Expand All @@ -335,7 +338,8 @@ private List<Object[]> buildJoinedDataBlockSemi(TransferableBlock leftBlock) thr
return rows;
}

private List<Object[]> buildJoinedDataBlockDefault(TransferableBlock leftBlock) throws ProcessingException {
private List<Object[]> buildJoinedDataBlockDefault(TransferableBlock leftBlock)
throws ProcessingException {
List<Object[]> container = leftBlock.getContainer();
ArrayList<Object[]> rows = new ArrayList<>(container.size());

Expand Down Expand Up @@ -385,7 +389,8 @@ private List<Object[]> buildJoinedDataBlockDefault(TransferableBlock leftBlock)
return rows;
}

private List<Object[]> buildJoinedDataBlockAnti(TransferableBlock leftBlock) throws ProcessingException {
private List<Object[]> buildJoinedDataBlockAnti(TransferableBlock leftBlock)
throws ProcessingException {
List<Object[]> container = leftBlock.getContainer();
List<Object[]> rows = new ArrayList<>(container.size());

Expand Down Expand Up @@ -475,7 +480,8 @@ private void earlyTerminateLeftInput() {
*
* @return {@code true} if the limit has been exceeded, {@code false} otherwise
*/
private boolean incrementJoinedRowsAndCheckLimit() throws ProcessingException {
private boolean incrementJoinedRowsAndCheckLimit()
throws ProcessingException {
_currentJoinedRows++;
if (_currentJoinedRows > _maxRowsInJoin) {
if (_joinOverflowMode == JoinOverFlowMode.THROW) {
Expand All @@ -494,7 +500,8 @@ private boolean incrementJoinedRowsAndCheckLimit() throws ProcessingException {
return false;
}

private void throwProcessingExceptionForJoinRowLimitExceeded(String reason) throws ProcessingException {
private void throwProcessingExceptionForJoinRowLimitExceeded(String reason)
throws ProcessingException {
ProcessingException resourceLimitExceededException =
new ProcessingException(QueryException.SERVER_RESOURCE_LIMIT_EXCEEDED_ERROR_CODE);
resourceLimitExceededException.setMessage(
Expand Down