[Feature] Add the ability to compress and decompress tar archive file with ZStandard and LZ4 compressors #13782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Luo <jluo14@ext.uber.com>
Signed-off-by: Jack Luo <jluo14@ext.uber.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13782 +/- ##
============================================
+ Coverage 61.75% 61.94% +0.19%
+ Complexity 207 198 -9
============================================
Files 2436 2558 +122
Lines 133233 141224 +7991
Branches 20636 21977 +1341
============================================
+ Hits 82274 87480 +5206
- Misses 44911 47078 +2167
- Partials 6048 6666 +618
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gortiz
approved these changes
Aug 12, 2024
pinot-common/src/main/java/org/apache/pinot/common/utils/TarCompressionUtils.java
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/TarCompressionUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jack Luo <jluo14@ext.uber.com>
Signed-off-by: Jack Luo <jluo14@ext.uber.com>
… class instance Signed-off-by: Jack Luo <jluo14@ext.uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances tar archive compression and decompression by adding support for ZStandard and LZ4, alongside GZip. The code is refactored for easy extensibility, allowing new compressors to be added with minimal effort if supported by Apache Commons Compress.
Compression typically infers the compressor from the file extension, but it can also be specified by name. Decompression uses magic numbers to automatically identify the compressor, utilizing Apache Commons Compress functionality.
This update is a step towards enabling ZStandard compression for segment data in Deepstore. As noted in the flamegraph profiling in issue #13319, GZip compression is currently a CPU bottleneck, consuming 5-10% of overall CPU usage in petabyte-scale production environments.