Skip to content

Fix query response time metric #13661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcvsubbu merged 3 commits into from
Jul 24, 2024
Merged

Fix query response time metric #13661

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ace556
Fix query response time metric
mcvsubbu Jul 18, 2024
2c97fb5
Changed as per review comments and offline discussion
mcvsubbu Jul 22, 2024
920e4f1
Added comments
mcvsubbu Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...er/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ public void shutDown() {
public BrokerResponse handleRequest(JsonNode request, @Nullable SqlNodeAndOptions sqlNodeAndOptions,
@Nullable RequesterIdentity requesterIdentity, RequestContext requestContext, @Nullable HttpHeaders httpHeaders)
throws Exception {
// Pinot installations may either use PinotClientRequest or this class in order to process a query that
// arrives via their custom container. The custom code may add its own overhead in either pre-processing
// or post-processing stages, and should be measured independently.
// In order to accommodate for both code paths, we set the request arrival time only if it is not already set.
if (requestContext.getRequestArrivalTimeMillis() <= 0) {
requestContext.setRequestArrivalTimeMillis(System.currentTimeMillis());
}
// Parse the query if needed
if (sqlNodeAndOptions == null) {
try {
Expand Down