Skip to content

Fix field spec data type for JSON predicate evaluator tests #13448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jackie-Jiang merged 1 commit into from
Jun 24, 2024
Merged

Fix field spec data type for JSON predicate evaluator tests #13448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...pache/pinot/core/operator/filter/predicate/NoDictionaryEqualsPredicateEvaluatorsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,11 +257,11 @@ public void testJsonPredicateEvaluators() {

EqPredicate eqPredicate = new EqPredicate(COLUMN_EXPRESSION, jsonString);
PredicateEvaluator eqPredicateEvaluator =
EqualsPredicateEvaluatorFactory.newRawValueBasedEvaluator(eqPredicate, FieldSpec.DataType.STRING);
EqualsPredicateEvaluatorFactory.newRawValueBasedEvaluator(eqPredicate, FieldSpec.DataType.JSON);

NotEqPredicate notEqPredicate = new NotEqPredicate(COLUMN_EXPRESSION, jsonString);
PredicateEvaluator neqPredicateEvaluator =
NotEqualsPredicateEvaluatorFactory.newRawValueBasedEvaluator(notEqPredicate, FieldSpec.DataType.STRING);
NotEqualsPredicateEvaluatorFactory.newRawValueBasedEvaluator(notEqPredicate, FieldSpec.DataType.JSON);

Assert.assertTrue(eqPredicateEvaluator.applySV(jsonString));
Assert.assertFalse(neqPredicateEvaluator.applySV(jsonString));
Expand Down
4 changes: 2 additions & 2 deletions ...org/apache/pinot/core/operator/filter/predicate/NoDictionaryInPredicateEvaluatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,11 +300,11 @@ public void testJsonPredicateEvaluators() {

InPredicate inPredicate = new InPredicate(COLUMN_EXPRESSION, jsonValues);
PredicateEvaluator inPredicateEvaluator =
InPredicateEvaluatorFactory.newRawValueBasedEvaluator(inPredicate, FieldSpec.DataType.STRING);
InPredicateEvaluatorFactory.newRawValueBasedEvaluator(inPredicate, FieldSpec.DataType.JSON);

NotInPredicate notInPredicate = new NotInPredicate(COLUMN_EXPRESSION, jsonValues);
PredicateEvaluator notInPredicateEvaluator =
NotInPredicateEvaluatorFactory.newRawValueBasedEvaluator(notInPredicate, FieldSpec.DataType.STRING);
NotInPredicateEvaluatorFactory.newRawValueBasedEvaluator(notInPredicate, FieldSpec.DataType.JSON);

for (String value : jsonValueSet) {
Assert.assertTrue(inPredicateEvaluator.applySV(value));
Expand Down