Skip to content

Fix bug preventing numeric casts for MV columns in filters using the multi-stage query engine #13425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jackie-Jiang merged 2 commits into from
Jun 22, 2024
Merged

Fix bug preventing numeric casts for MV columns in filters using the multi-stage query engine #13425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d1bedd
Fix bug preventing numeric casts for MV columns in filters using the …
yashmayya Jun 18, 2024
d3a3275
Re-order if statements
yashmayya Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .../src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,13 @@ private static DataType getDataType(Expression expression, Schema schema) {
String targetTypeLiteral =
expression.getFunctionCall().getOperands().get(1).getLiteral().getStringValue().toUpperCase();
DataType dataType;

// Strip out _ARRAY suffix that can be used to represent an MV field type since the semantics here will be the
// same as that for the equivalent SV field of the same type
if (targetTypeLiteral.endsWith("_ARRAY")) {
targetTypeLiteral = targetTypeLiteral.substring(0, targetTypeLiteral.length() - 6);
}

if ("INTEGER".equals(targetTypeLiteral)) {
dataType = DataType.INT;
} else if ("VARCHAR".equals(targetTypeLiteral)) {
Expand Down
8 changes: 8 additions & 0 deletions ...sts/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,6 +793,14 @@ public void testSearch()
assertNoError(jsonNode);
}

@Test
public void testMVNumericCastInFilter() throws Exception {
String sqlQuery = "SELECT COUNT(*) FROM mytable WHERE arrayToMV(CAST(DivAirportIDs AS BIGINT ARRAY)) > 0";
JsonNode jsonNode = postQuery(sqlQuery);
assertNoError(jsonNode);
assertEquals(jsonNode.get("resultTable").get("rows").get(0).get(0).asInt(), 15482);
}

@Override
protected String getTableName() {
return _tableName;
Expand Down