[Multi-stage] Fix literal handling#13344
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Jun 8, 2024
Merged
Conversation
Contributor
Jackie-Jiang
commented
Jun 8, 2024
- Ensure literal is properly handled for all types
- Explicitly handle SYMBOL and NULL
- Also fixes a minor bug in stats collection which can cause NPE after query fails
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13344 +/- ##
============================================
+ Coverage 61.75% 62.05% +0.30%
+ Complexity 207 198 -9
============================================
Files 2436 2545 +109
Lines 133233 139720 +6487
Branches 20636 21675 +1039
============================================
+ Hits 82274 86702 +4428
- Misses 44911 46456 +1545
- Partials 6048 6562 +514
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
approved these changes
Jun 8, 2024
8e26655 to
908f611
Compare
gortiz
pushed a commit
to gortiz/pinot
that referenced
this pull request
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.