Skip to content

Fix the NPE from IS update metrics#13313

Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:fix_is_monitoring
Jun 4, 2024
Merged

Fix the NPE from IS update metrics#13313
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:fix_is_monitoring

Conversation

@Jackie-Jiang
Copy link
Contributor

Fix the NPE introduced in #13266
When updateIdealState() is invoked from broker, it can throw NPE because ControllerMetrics is not registered.

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 61.99%. Comparing base (59551e4) to head (2ec9f75).
Report is 551 commits behind head on master.

Files Patch % Lines
...g/apache/pinot/common/utils/helix/HelixHelper.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13313      +/-   ##
============================================
+ Coverage     61.75%   61.99%   +0.24%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2538     +102     
  Lines        133233   139499    +6266     
  Branches      20636    21593     +957     
============================================
+ Hits          82274    86482    +4208     
- Misses        44911    46518    +1607     
- Partials       6048     6499     +451     
Flag Coverage Δ
custom-integration1 ?
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 61.99% <0.00%> (+0.28%) ⬆️
java-21 <0.01% <0.00%> (-61.63%) ⬇️
skip-bytebuffers-false 61.99% <0.00%> (+0.24%) ⬆️
skip-bytebuffers-true <0.01% <0.00%> (-27.73%) ⬇️
temurin 61.99% <0.00%> (+0.24%) ⬆️
unittests 61.99% <0.00%> (+0.24%) ⬆️
unittests1 46.51% <0.00%> (-0.39%) ⬇️
unittests2 27.76% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 970d9b9 into apache:master Jun 4, 2024
@Jackie-Jiang Jackie-Jiang deleted the fix_is_monitoring branch June 4, 2024 20:15
@gortiz
Copy link
Contributor

gortiz commented Jun 5, 2024

I've created a NOOP registry in #13032, so this kind of issues shouldn't be problematic in the future.

gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants