Skip to content

Remove SqlKind from FunctionCall#13293

Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:remove_sql_kind
Jun 2, 2024
Merged

Remove SqlKind from FunctionCall#13293
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:remove_sql_kind

Conversation

@Jackie-Jiang
Copy link
Contributor

Follow up on #13221 to not serialize SqlKind in FunctionCall because it is not safe to use its ordinal.

In order to achieve this:

  • Move the function name handling logic to the broker side
  • Cleanup and simplify server side RexExpression handling
  • Remove getKind() and getDataType() from RexExpression interface

@Jackie-Jiang Jackie-Jiang added backward-incompat Referenced by PRs that introduce or fix backward compat issues bugfix cleanup multi-stage Related to the multi-stage query engine labels Jun 2, 2024
@Jackie-Jiang Jackie-Jiang requested a review from xiangfu0 June 2, 2024 01:56
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 86.23853% with 15 lines in your changes missing coverage. Please review.

Project coverage is 62.13%. Comparing base (59551e4) to head (c60d91a).
Report is 2306 commits behind head on master.

Files with missing lines Patch % Lines
...pinot/query/parser/CalciteRexExpressionParser.java 84.09% 1 Missing and 6 partials ⚠️
...inot/query/planner/logical/RexExpressionUtils.java 81.25% 2 Missing and 4 partials ⚠️
.../planner/serde/RexExpressionToProtoExpression.java 87.50% 0 Missing and 1 partial ⚠️
...ime/operator/operands/TransformOperandFactory.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13293      +/-   ##
============================================
+ Coverage     61.75%   62.13%   +0.37%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2534      +98     
  Lines        133233   139202    +5969     
  Branches      20636    21525     +889     
============================================
+ Hits          82274    86488    +4214     
- Misses        44911    46236    +1325     
- Partials       6048     6478     +430     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.08% <86.23%> (+0.37%) ⬆️
java-21 62.02% <86.23%> (+0.39%) ⬆️
skip-bytebuffers-false 62.11% <86.23%> (+0.36%) ⬆️
skip-bytebuffers-true 61.97% <86.23%> (+34.25%) ⬆️
temurin 62.13% <86.23%> (+0.37%) ⬆️
unittests 62.12% <86.23%> (+0.37%) ⬆️
unittests1 46.67% <86.23%> (-0.22%) ⬇️
unittests2 27.78% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jackie-Jiang Jackie-Jiang merged commit a4950fe into apache:master Jun 2, 2024
gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backward-incompat Referenced by PRs that introduce or fix backward compat issues bugfix cleanup multi-stage Related to the multi-stage query engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants