Remove SqlKind from FunctionCall#13293
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Jun 2, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13293 +/- ##
============================================
+ Coverage 61.75% 62.13% +0.37%
+ Complexity 207 198 -9
============================================
Files 2436 2534 +98
Lines 133233 139202 +5969
Branches 20636 21525 +889
============================================
+ Hits 82274 86488 +4214
- Misses 44911 46236 +1325
- Partials 6048 6478 +430
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiangfu0
approved these changes
Jun 2, 2024
gortiz
pushed a commit
to gortiz/pinot
that referenced
this pull request
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #13221 to not serialize
SqlKindinFunctionCallbecause it is not safe to use its ordinal.In order to achieve this:
RexExpressionhandlinggetKind()andgetDataType()fromRexExpressioninterface