Add a plan version field to QueryRequest Protobuf Message#13267
Merged
Jackie-Jiang merged 6 commits intoapache:masterfrom May 31, 2024
Merged
Add a plan version field to QueryRequest Protobuf Message#13267Jackie-Jiang merged 6 commits intoapache:masterfrom
Jackie-Jiang merged 6 commits intoapache:masterfrom
Conversation
vrajat
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13267 +/- ##
============================================
+ Coverage 61.75% 62.14% +0.39%
+ Complexity 207 198 -9
============================================
Files 2436 2536 +100
Lines 133233 139403 +6170
Branches 20636 21548 +912
============================================
+ Hits 82274 86634 +4360
- Misses 44911 46280 +1369
- Partials 6048 6489 +441
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#13221 will provide backward and forward compatibility of the serialization format as long as best practices are followed. However, this is not sufficient to support rolling upgrades for V2 workloads.
V2 Plan versioning is required because the semantics of a plan may change. Some examples are:
This implies that newer brokers & servers have to support multiple plan versions and they have to choose to use older plan versions while the upgrade is in progress.
As a first step, a plan version field is added to
QueryRequestmessage as a string field. The field can be used to make sure that two components are communicating using the same version.In the future, the best practices on how to manage plan versions as well as features to choose the right plan versions in mixed mode clusters will be implemented.
Tags:
multi-stage