Skip to content

Bugfix: Validate minionInstanceTag during task-generation #13092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankitsultana merged 2 commits into from
May 9, 2024
Merged

Bugfix: Validate minionInstanceTag during task-generation #13092

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85d7812
Bugfix: Validate minionInstanceTag during task-generation
tibrewalpratik17 May 6, 2024
a0047f1
address comments
tibrewalpratik17 May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...troller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,11 @@ private List<String> scheduleTask(PinotTaskGenerator taskGenerator, List<TableCo
int numTasks = pinotTaskConfigs.size();
try {
if (numTasks > 0) {
if (_pinotHelixResourceManager.getInstancesWithTag(minionInstanceTag).isEmpty()) {
LOGGER.error("Skipping {} tasks for task type: {} with task configs: {} to invalid minionInstanceTag: {}",
numTasks, taskType, pinotTaskConfigs, minionInstanceTag);
throw new IllegalArgumentException("No valid minion instance found for tag: " + minionInstanceTag);
}
// This might lead to lot of logs, maybe sum it up and move outside the loop
LOGGER.info("Submitting {} tasks for task type: {} to minionInstance: {} with task configs: {}", numTasks,
taskType, minionInstanceTag, pinotTaskConfigs);
Expand Down