Using local copy of segment instead of downloading from remote #12863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12863 +/- ##
============================================
+ Coverage 61.75% 62.04% +0.28%
+ Complexity 207 198 -9
============================================
Files 2436 2502 +66
Lines 133233 136414 +3181
Branches 20636 21106 +470
============================================
+ Hits 82274 84633 +2359
- Misses 44911 45503 +592
- Partials 6048 6278 +230
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
swaminathanmanish
changed the title
swaminathanmanish
changed the title
swaminathanmanish
changed the title
swaminathanmanish
force-pushed
the
pushOptimization.1
branch
from
ba01cec to
5b8ec49
Compare
|
@klsince - Could you take a look? |
swaminathanmanish
force-pushed
the
pushOptimization.1
branch
from
5b8ec49 to
ce49203
Compare
swaminathanmanish
added a commit
to swaminathanmanish/pinot
that referenced
this pull request
May 9, 2024
apache#12863)" This reverts commit af8fd40.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats in the PR:
Local copy of segment is used to extract segment metadata.
Why its needed:
Segment is available locally (segment generation creates it) which can be used to extract metadata. Currently we are downloading segment from deep store which takes ~7-8 seconds per segment of size ~400Mb and there's unnecessary call to deep store. Removing this download, will speed minion execution by orders of seconds to minutes per minion.