[Multi-stage] Optimize query plan serialization#12370
[Multi-stage] Optimize query plan serialization#12370Jackie-Jiang merged 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
This is used to ser/de the map
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12370 +/- ##
============================================
- Coverage 61.71% 61.69% -0.03%
Complexity 207 207
============================================
Files 2426 2425 -1
Lines 132776 132707 -69
Branches 20541 20529 -12
============================================
- Hits 81946 81871 -75
- Misses 44817 44823 +6
Partials 6013 6013
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
walterddr
left a comment
There was a problem hiding this comment.
lgtm. only reviewed the non-test portion.
There was a problem hiding this comment.
lol we should do license check better
There was a problem hiding this comment.
seems like all auto-formatting? (skipping most of these kinds)
There was a problem hiding this comment.
This is a simple helper class to help organize the info for each stage.
There was a problem hiding this comment.
was this change related to Ser/De or just test optimization?
There was a problem hiding this comment.
Moving the per method setup to per class is test optimization
bb47fb1 to
8b13ea0
Compare
8b13ea0 to
9de696f
Compare
9de696f to
af2c506
Compare
Optimize the query plan ser-de by:
Backward Incompatible
This PR changes the proto object structure, which will cause backward incompatibility when broker and server are running different version. Since we are not maintaining backward compatibility for multi-stage engine as of now, user should upgrade both brokers and servers, then start querying.