[multistage][bugfix] fix literal query return multiple duplicate results#12240
Merged
walterddr merged 1 commit intoapache:masterfrom Jan 8, 2024
Merged
[multistage][bugfix] fix literal query return multiple duplicate results#12240walterddr merged 1 commit intoapache:masterfrom
walterddr merged 1 commit intoapache:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12240 +/- ##
============================================
- Coverage 61.53% 61.50% -0.03%
Complexity 207 207
============================================
Files 2416 2416
Lines 131177 131181 +4
Branches 20245 20247 +2
============================================
- Hits 80717 80685 -32
- Misses 44570 44601 +31
- Partials 5890 5895 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
approved these changes
Jan 8, 2024
Contributor
xiangfu0
left a comment
xiangfu0
left a comment
There was a problem hiding this comment.
lgtm, can you add one example in integration tests and quickstart?
Contributor
Author
this one is trivial and i dont think we need an integration test. we will once we support a more complex literal join table type queries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes #11821