Skip to content

[multistage][hotfix] add back filter merge after rule#11989

Merged
walterddr merged 1 commit intoapache:masterfrom
walterddr:hotfix_merge_rule_post_exchange
Nov 10, 2023
Merged

[multistage][hotfix] add back filter merge after rule#11989
walterddr merged 1 commit intoapache:masterfrom
walterddr:hotfix_merge_rule_post_exchange

Conversation

@walterddr
Copy link
Contributor

@walterddr walterddr commented Nov 10, 2023

for some reason we missed this rule the whole time, adding it back

@walterddr walterddr added bugfix multi-stage Related to the multi-stage query engine labels Nov 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Merging #11989 (6257a3a) into master (2beb9a4) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #11989      +/-   ##
============================================
+ Coverage     61.61%   61.63%   +0.02%     
  Complexity      207      207              
============================================
  Files          2385     2385              
  Lines        129214   129214              
  Branches      20003    20003              
============================================
+ Hits          79613    79639      +26     
+ Misses        43801    43773      -28     
- Partials       5800     5802       +2     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (ø)
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 61.57% <ø> (-0.02%) ⬇️
java-21 61.51% <ø> (+0.03%) ⬆️
skip-bytebuffers-false 61.61% <ø> (+<0.01%) ⬆️
skip-bytebuffers-true 61.46% <ø> (+33.88%) ⬆️
temurin 61.63% <ø> (+0.02%) ⬆️
unittests 61.62% <ø> (+0.02%) ⬆️
unittests1 46.97% <ø> (+0.02%) ⬆️
unittests2 27.59% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@walterddr walterddr merged commit b38bd9f into apache:master Nov 10, 2023
walterddr added a commit that referenced this pull request Nov 13, 2023
following up on #11989.
adding more tests for filter pushdown rules on the runtime side.

Co-authored-by: Rong Rong <rongr@startree.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix multi-stage Related to the multi-stage query engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants