Skip to content

[draft] Null mode at query time#11935

Closed
gortiz wants to merge 15 commits intoapache:masterfrom
gortiz:null-mode
Closed

[draft] Null mode at query time#11935
gortiz wants to merge 15 commits intoapache:masterfrom
gortiz:null-mode

Conversation

@gortiz
Copy link
Contributor

@gortiz gortiz commented Nov 2, 2023

This PR is an attempt to implement an alternative implementation to correctly support null in V2. Changes were build on top of #11824, but NullValueIndexType was reverted to what we have in master

Semantic table:

nullMode Segment has null vector FieldSpec* in master in PR
none N/A N/A not null not null
all false N/A not null not null
all true N/A null null
column false N/A N/A null
column true false (default) N/A not null
column true true N/A null

It is to be defined how to change nullMode. At this time what I choose was:

  • If useColumnNullability query option is true, then use column nullMode
  • else if enableNullHandling query option is true, then use all nullMode
  • else use none null mode

@gortiz gortiz marked this pull request as draft November 2, 2023 13:19
@gortiz
Copy link
Contributor Author

gortiz commented Nov 2, 2023

Tests haven't been modified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant