[multistage][hotfix] add special column escape test cases#11737
Merged
walterddr merged 2 commits intoapache:masterfrom Oct 4, 2023
Merged
[multistage][hotfix] add special column escape test cases#11737walterddr merged 2 commits intoapache:masterfrom
walterddr merged 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11737 +/- ##
============================================
- Coverage 63.12% 63.09% -0.03%
Complexity 1118 1118
============================================
Files 2342 2342
Lines 125889 125919 +30
Branches 19360 19362 +2
============================================
- Hits 79462 79450 -12
- Misses 40783 40821 +38
- Partials 5644 5648 +4
Flags with carried forward coverage won't be shown. Click here to find out more. see 32 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding the missing test cases for dash/dot column naming and table escapes
we use to only have quoted identifier tests on LexicalStructure test cases but only on columns.