Skip to content

[multistage][hotfix] fix custom property naming #11675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jackie-Jiang merged 1 commit into from
Sep 25, 2023
Merged

[multistage][hotfix] fix custom property naming #11675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...time/src/main/java/org/apache/pinot/query/runtime/operator/MultistageGroupByExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public MultistageGroupByExecutor(int[] groupKeyIds, AggregationFunction[] aggFun
_groupKeyToIdMap.defaultReturnValue(GroupKeyGenerator.INVALID_ID);
}

private int getNumGroupsLimit(Map<String, String> customProperties, @Nullable AbstractPlanNode.NodeHint nodeHint) {
private int getNumGroupsLimit(Map<String, String> opChainMetadata, @Nullable AbstractPlanNode.NodeHint nodeHint) {
if (nodeHint != null) {
Map<String, String> aggregateOptions = nodeHint._hintOptions.get(PinotHintOptions.AGGREGATE_HINT_OPTIONS);
if (aggregateOptions != null) {
Expand All @@ -106,11 +106,11 @@ private int getNumGroupsLimit(Map<String, String> customProperties, @Nullable Ab
}
}
}
Integer numGroupsLimit = QueryOptionsUtils.getNumGroupsLimit(customProperties);
Integer numGroupsLimit = QueryOptionsUtils.getNumGroupsLimit(opChainMetadata);
return numGroupsLimit != null ? numGroupsLimit : InstancePlanMakerImplV2.DEFAULT_NUM_GROUPS_LIMIT;
}

private int getMaxInitialResultHolderCapacity(Map<String, String> customProperties,
private int getMaxInitialResultHolderCapacity(Map<String, String> opChainMetadata,
@Nullable AbstractPlanNode.NodeHint nodeHint) {
if (nodeHint != null) {
Map<String, String> aggregateOptions = nodeHint._hintOptions.get(PinotHintOptions.AGGREGATE_HINT_OPTIONS);
Expand All @@ -122,7 +122,7 @@ private int getMaxInitialResultHolderCapacity(Map<String, String> customProperti
}
}
}
Integer maxInitialResultHolderCapacity = QueryOptionsUtils.getMaxInitialResultHolderCapacity(customProperties);
Integer maxInitialResultHolderCapacity = QueryOptionsUtils.getMaxInitialResultHolderCapacity(opChainMetadata);
return maxInitialResultHolderCapacity != null ? maxInitialResultHolderCapacity
: InstancePlanMakerImplV2.DEFAULT_MAX_INITIAL_RESULT_HOLDER_CAPACITY;
}
Expand Down