Skip to content

Fix NPE in SingleColumnKeySelector#11644

Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:fix_key_selector_npe
Sep 21, 2023
Merged

Fix NPE in SingleColumnKeySelector#11644
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:fix_key_selector_npe

Conversation

@Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented Sep 21, 2023

This bug was introduced in #11630

@Jackie-Jiang Jackie-Jiang added bugfix multi-stage Related to the multi-stage query engine labels Sep 21, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #11644 (9c7b52b) into master (a96e36e) will decrease coverage by 48.68%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #11644       +/-   ##
=============================================
- Coverage     63.13%   14.45%   -48.68%     
+ Complexity     1121      201      -920     
=============================================
  Files          2335     2335               
  Lines        125208   125208               
  Branches      19208    19209        +1     
=============================================
- Hits          79046    18098    -60948     
- Misses        40533   105585    +65052     
+ Partials       5629     1525     -4104     
Flag Coverage Δ
integration ?
integration1 ?
integration2 ?
java-11 14.45% <0.00%> (-48.64%) ⬇️
java-17 ?
java-20 14.45% <0.00%> (-48.54%) ⬇️
temurin 14.45% <0.00%> (-48.68%) ⬇️
unittests 14.45% <0.00%> (-48.68%) ⬇️
unittests1 ?
unittests2 14.45% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...t/query/planner/partitioning/EmptyKeySelector.java 0.00% <0.00%> (-75.00%) ⬇️
.../pinot/query/planner/partitioning/KeySelector.java 0.00% <ø> (ø)
.../planner/partitioning/SingleColumnKeySelector.java 0.00% <0.00%> (-100.00%) ⬇️

... and 1510 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang merged commit 09c1385 into apache:master Sep 21, 2023
@Jackie-Jiang Jackie-Jiang deleted the fix_key_selector_npe branch September 21, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix multi-stage Related to the multi-stage query engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants