Remove/Deprecate HLC handling code#11590
Merged
Jackie-Jiang merged 2 commits intoapache:masterfrom Sep 16, 2023
Merged
Conversation
Contributor
Jackie-Jiang
commented
Sep 14, 2023
Jackie-Jiang
commented
- Removed classes:
- HLCSegmentName
- SegmentName.RealtimeSegmentType
- PinotRealtimeSegmentManager
- ReplicationUtils
- StreamConfig.ConsumerType
- Deprecated classes:
- SegmentName
- PartitionLevelStreamConfig
Jackie-Jiang
added
incompatible
Jackie-Jiang
force-pushed
the
remove_hlc_handling
branch
from
a93df8a to
1bf8304
Compare
Jackie-Jiang
force-pushed
the
remove_hlc_handling
branch
from
1bf8304 to
5ffdda6
Compare
Codecov Report
@@ Coverage Diff @@
## master #11590 +/- ##
============================================
+ Coverage 63.06% 63.16% +0.10%
+ Complexity 1107 1106 -1
============================================
Files 2326 2323 -3
Lines 124928 124405 -523
Branches 19073 18981 -92
============================================
- Hits 78787 78586 -201
+ Misses 40542 40239 -303
+ Partials 5599 5580 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
force-pushed
the
remove_hlc_handling
branch
from
5ffdda6 to
246f93e
Compare
Contributor
|
I think we also want to deprecate |
xiangfu0
approved these changes
Sep 15, 2023
walterddr
reviewed
Sep 20, 2023
Contributor
walterddr
left a comment
walterddr
left a comment
There was a problem hiding this comment.
missed this PR but this is AWESOME!!!!
walterddr
reviewed
Sep 20, 2023
| int numSeparators = getNumSeparators(segmentName); | ||
| return numSeparators == 2 || numSeparators == 4; | ||
| @Deprecated | ||
| public class SegmentName { |
Contributor
There was a problem hiding this comment.
this class can be removed?
Contributor
Author
There was a problem hiding this comment.
Kept SegmentName and PartitionLevelStreamConfig for compatibility. Will remove in next release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.