[multistage] fix usage of metadata overrides#11587
[multistage] fix usage of metadata overrides#11587Jackie-Jiang merged 5 commits intoapache:masterfrom
Conversation
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/StageMetadata.java
Outdated
Show resolved
Hide resolved
...query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/OpChainExecutionContext.java
Outdated
Show resolved
Hide resolved
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java
Show resolved
Hide resolved
...t-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java
Outdated
Show resolved
Hide resolved
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java
Show resolved
Hide resolved
| // first put all custom Properties | ||
| requestMetadata.putAll(customProperties); | ||
| // put all overrides from request | ||
| requestMetadata.putAll(requestMetadataOriginal); |
There was a problem hiding this comment.
I think we should put request level metadata first, then override the stage level custom property
There was a problem hiding this comment.
this changes the previous behavior. i will separate that into a different PR outside of this bugfix
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java
Outdated
Show resolved
Hide resolved
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 88 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
custom properties in StageMetadata and
requestMetadata from WorkerRequest are immutable
mutating it during execution causes race-condition in set b/c multiple worker shares the same metadata
thus