[multistage] disable calcite float to double cast#11518
Merged
xiangfu0 merged 4 commits intoapache:masterfrom Sep 6, 2023
Merged
[multistage] disable calcite float to double cast#11518xiangfu0 merged 4 commits intoapache:masterfrom
xiangfu0 merged 4 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11518 +/- ##
============================================
- Coverage 63.08% 63.07% -0.02%
Complexity 1108 1108
============================================
Files 2320 2320
Lines 124597 124598 +1
Branches 19022 19022
============================================
- Hits 78604 78586 -18
- Misses 40385 40411 +26
+ Partials 5608 5601 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
approved these changes
Sep 6, 2023
zhtaoxiang
added a commit
to zhtaoxiang/pinot
that referenced
this pull request
Sep 7, 2023
This was referenced Jul 16, 2024
Contributor
|
We are going to rollback this change in #13616 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map float and double to the same RelDataType to disable calcite float to double cast so that queries like
select count(*) from table where aFloatColumn = 0.05works correctly in multi-stage query engine.Without this PR,
select count(*) from table where aFloatColumn = 0.05will be converted toselect count(*) from table where CAST(aFloatColumn as "DOUBLE") = 0.05. While casting from float to double does not always produce the same double value as the original float value, this leads to wrong query result.With this PR, the behavior in multi-stage query engine will be the same as the query in v1 query engine.